[FIX] website_apps_store: avoid useless postgres requests#96
Open
[FIX] website_apps_store: avoid useless postgres requests#96
Conversation
4 tasks
this core were calling super but overwriting most of the result. stop calling super and reuses lastest odoo version as well which stop calling search_count this is done while managing performance issue on OCA community instance
petrus-v
force-pushed
the
14.0-improve-perf
branch
from
f841816 to
53d7b49
Compare
| "product_variant_ids.product_template_attribute_value_ids" | ||
| + ".product_attribute_value_id.id" | ||
| ) | ||
| domain += [ |
There was a problem hiding this comment.
Details but:
- using
osv.expression.AND()is better in terms of readability - is calling twice
post.get(...)enhanced by adding variables ?
Author
There was a problem hiding this comment.
thanks for review !
Yeah I was just moving code ! you are right, will improve that :)
|
/ocabot rebase |
Contributor
|
Sorry @thomaspaulb you are not allowed to rebase. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
Author
|
@thomaspaulb I've start to take care @rousseldenis suggestion and orther details during code sprint but haven't pushed yet ! but not sure to be able to do it in the next 15 days... |
|
Yes i tried the rebase for another reason, that i pinged you on the task, but it would not have helped i think. So take your time!
3 okt. 2025 15:51:48 Pierre Verkest ***@***.***>:
…
[Afbeelding]*petrus-v* left a comment (OCA/apps-store#96)[#96 (comment)]
@thomaspaulb[https://github.com/thomaspaulb] I've start to take care @rousseldenis[https://github.com/rousseldenis] suggestion and orther details during code sprint but haven't pushed yet ! but not sure to be able to do it in the next 15 days...
—
Reply to this email directly, view it on GitHub[#96 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AALF75CCHJT4LTTHJASOFGL3VZ5OXAVCNFSM6AAAAACFCS6KPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNRVG43DAOJRHE].
You are receiving this because you were mentioned.
[Tracking afbeelding][https://github.com/notifications/beacon/AALF75HMELYNZ67B3YKPEBT3VZ5OXA5CNFSM6AAAAACFCS6KPOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTWITVXZO.gif]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code were calling super but overwriting most of the result.
So, stop calling super() and reuses lastest odoo version as well which stop calling search_count
This is done while managing performance issue on OCA community instance
cf run 2 on locust report here: OCA/oca-custom#62